Re: [PATCH bpf-next] selftests/bpf: Track test_xdp_features DUT processes
Jiayuan Chen <[email protected]> Wed, 5 Aug 2026 16:18:26 +0800
| Newsgroups | org.kernel.vger.bpf,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 8/5/26 3:29 PM, Bochao Cao via B4 Relay wrote: > From: Bochao Cao <[email protected]> > > test_xdp_features.sh waits for any xdp_features listener to appear and > uses pidof during cleanup. A concurrent test can therefore make another > test proceed before its own DUT is ready, and cleanup kills every > xdp_features process on the host. The readiness loop also has no timeout, > so a DUT that exits before listening leaves the test hung indefinitely. > > Record each DUT PID when it is spawned, wait for ss to report that exact > PID with a bounded retry loop, and only terminate and reap recorded > children. Install an EXIT trap and signal handlers so failure paths also > remove child processes and network setup. > > This also removes the runtime dependency on pidof. > > Fixes: 4dba3e7852b7 ("selftests/bpf: introduce XDP compliance test tool") > Closes: https://bugs.debian.org/1136522 It looks like part of the motivation here is dropping the pidof dependency? I don't think that's worth optimizing. Selftests already require a bunch of tools from non-essential packages (ip, ss and ethtool in this very script)