Re: [RFC PATCH bpf-next v5 2/8] selftests/bpf: drop stale and no-op lines
Mykola Lysenko <[email protected]>
| Newsgroups | org.kernel.vger.bpf |
|---|---|
| Message-ID | <CAMtxOX1Sfi4ispM9suGXKPaRss3bZ_rxAYCfvc+vv-J-d6-dmg@mail.gmail.com> |
On Wed, Aug 5, 2026 at 2:28 PM Eduard Zingerman <[email protected]> wrote: > > On Tue, 2026-08-04 at 10:01 -0700, Mykola Lysenko wrote: > > ... > > > @@ -480,11 +479,14 @@ BPF_CFLAGS = -g -Wall -Werror -D__TARGET_ARCH_$(SRCARCH) $(MENDIAN) \ > > > > CLANG_CFLAGS = $(CLANG_SYS_INCLUDES) > > > > -$(OUTPUT)/test_l4lb_noinline.o: BPF_CFLAGS += -fno-inline > > -$(OUTPUT)/test_xdp_noinline.o: BPF_CFLAGS += -fno-inline > > +$(OUTPUT)/flow_dissector_load: flow_dissector_load.h > > > > -$(OUTPUT)/flow_dissector_load.o: flow_dissector_load.h > > -$(OUTPUT)/cgroup_getset_retval_hooks.o: cgroup_getset_retval_hooks.h > > +# progs/cgroup_getset_retval_hooks.c includes this top-directory header, > > +# which the progs/*.h prerequisite of the BPF object rules does not > > +# cover. > > +$(addprefix $(OUTPUT)/,cgroup_getset_retval_hooks.bpf.o \ > > + $(addsuffix /cgroup_getset_retval_hooks.bpf.o,$(TEST_INST_SUBDIRS))): \ > > + cgroup_getset_retval_hooks.h > > Would it be easier to just move cgroup_getset_retval_hooks.h under progs/? Yes, that is simpler, thanks - will do in v6.