Re: [PATCH bpf-next v2 1/6] resolve_btfids: Deduplicate BTF after btf2btf transformations
Eduard Zingerman <[email protected]>
| Newsgroups | org.kernel.vger.bpf |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 2026-08-05 at 16:06 -0700, Ihor Solodrai wrote: > btf2btf() adds new types to the BTF: the KF_IMPLICIT_ARGS transform > synthesizes an _impl FUNC together with its FUNC_PROTO and copies of the > kfunc's decl tags. Nothing deduplicates them afterwards. pahole runs > btf__dedup() on its own output, but that happens before resolve_btfids > sees the BTF, so any type the tool itself creates is emitted as-is, even > when a structurally identical type is already present. > > Call btf__dedup() at the start of finalize_btf(), so that base > distillation and the by-name sort both operate on the canonical set of > types. > > Signed-off-by: Ihor Solodrai <[email protected]> > --- Hi Ihor, I'm curious if you had a chance to measure how this affects the resolve_btfids running time?