Re: [PATCH bpf-next v2 6/6] docs, resolve_btfids: Document kfunc BTF annotation emission

Eduard Zingerman <[email protected]>
Newsgroups org.kernel.vger.bpf
Message-ID <[email protected]>
On Thu, 2026-08-06 at 14:06 -0700, Ihor Solodrai wrote:

...

> > > @@ -14,6 +14,9 @@ pahole-flags-$(call test-ge, $(pahole-ver), 125)	+= --skip_encoding_btf_inconsis
> > >  else
> > >  
> > >  # Switch to using --btf_features for v1.26 and later.
> > > +#
> > > +# kfunc BTF annotations (bpf_kfunc/bpf_fastcall decl tags and the arena
> > > +# address_space(1) type attribute) are emitted by resolve_btfids, not pahole.
> > 
> > What's the point of this comment?
> 
> The point is to inform the reader "where did decl_tag_kfuncs go?".
> Question is whether the git log will be enough, or is a comment
> also appropriate?

I don't think we don't do this usually. E.g. it would be a first such
comment in this makefile. Also, the comment looks suspiciously like
something Claude inserts :)

> > 
> > >  pahole-flags-$(call test-ge, $(pahole-ver), 126)  = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func
> > >  
> > >  pahole-flags-$(call test-ge, $(pahole-ver), 131) += --btf_features=layout
> > 
> > ...
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.