[PATCH bpf-next v3 0/3] bpftool: fix batch file handling issues

[email protected]
Newsgroups org.kernel.vger.bpf
Message-ID <[email protected]>
From: Yuan Chen <[email protected]>

This series fixes three issues in bpftool's batch file handling:

 1. map dump closes the map fd twice (introduced by the map-by-name
    dump refactor).
 2. do_batch() reports a spurious read failure because a stale errno
    from a previously executed command is used instead of checking the
    FILE stream state.
 3. (new in v3) a line longer than the batch buffer that contains a '#'
    within the buffered prefix bypasses the line length check: the
    comment stripping truncates the buffer before the length is
    checked, so the unread remainder of the line is parsed and executed
    as a separate command on the next loop iteration.

Changes in v3:
  - Add patch 3 fixing the pre-existing comment-stripping bypass of the
    batch line length check, as pointed out in review of v2.

Changes in v2:
  - Patch 2 now uses ferror() to detect read failures and tracks an
    overlong line explicitly instead of relying on errno; Fixes tag
    corrected to 71bb428fe2c1.

Yuan Chen (3):
  bpftool: fix double close in map dump
  bpftool: fix spurious batch file read error
  bpftool: Fix bypass of the batch line length check by comments

 tools/bpf/bpftool/main.c | 12 +++++++++---
 tools/bpf/bpftool/map.c  |  1 -
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.54.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.