Re: [PATCH bpf-next v2 1/6] bpf: Derive the atomic load register in one place
Eduard Zingerman <[email protected]>
| Newsgroups | org.kernel.vger.bpf |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 2026-08-11 at 00:18 +0200, Daniel Borkmann wrote: > check_atomic_rmw() open codes the mapping from a BPF_ATOMIC to the register > it reads the old value into, the BPF_STX case of insn_def_regno() open codes > the very same mapping a second time, and BPF JITs need it as well to know > which register a faulting BPF_PROBE_ATOMIC has to clear. Having the > derivations sit in different files is how the JITs came to disagree with > the verifier in the first place. Add a small helper so that all of them can > share it. No functional change. The BPF_LOAD_ACQ case is there for the JITs, > which do walk all instruction classes. > > Signed-off-by: Daniel Borkmann <[email protected]> > --- Acked-by: Eduard Zingerman <[email protected]> ...