Re: [PATCH bpf-next v2 2/2] selftests/bpf: Test resolve_btfids arena argument suffixes
| Newsgroups | org.kernel.vger.bpf |
|---|---|
| Message-ID | <aaac1d4309af7156ec7bd359800ddc8874c1b1aa73751c45f5a068765742cd7a@mail.kernel.org> |
> selftests/bpf: Test resolve_btfids arena argument suffixes > > Add a suffix-only kfunc declaration with arena annotations on all five > arguments. Verify that resolve_btfids emits address_space(1) type tags > for every position without KF_ARENA_ARG flags in the BTF ID sets. > > Represent expected arena arguments as a per-parameter bitmap so the > test covers suffixes beyond the two positions expressible by flags. > > Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]> This isn't a bug, but would it be worth mentioning kfunc_f and kfunc_g in the changelog? The description talks about "a suffix-only kfunc declaration with arena annotations on all five arguments" (which is kfunc_e), but the patch also adds kfunc_f (a mixed prototype where only the second of three parameters is suffixed and the third is a non-pointer) and kfunc_g (suffixes combined with KF_ARENA_RET). kfunc_f and kfunc_g arguably cover more interesting cases since they pin down that unsuffixed and non-pointer parameters stay untagged and that suffixes and flags compose. --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31635245405