Re: [PATCH bpf-next v1 09/14] selftests/bpf: Test non-sleepable kfunc context
| Newsgroups | org.kernel.vger.bpf |
|---|---|
| Message-ID | <efa4d56d82320fdad512a4a2f01e26b9c578962cfe8f525c3887ef5b5e5f9625@mail.kernel.org> |
> selftests/bpf: Test non-sleepable kfunc context > > Exercise a non-sleepable tracing program that enters an RCU read lock region > before calling a sleepable kfunc. Assert both the legacy verifier message and > the structured reason based on the program's sleepability. > > This distinguishes the program-level rejection from the later check for a > sleepable program calling an operation inside an active critical section. This isn't a bug, but since the previous patch folded both diagnostics into one site in check_kfunc_call(), would it read more clearly to say this distinguishes the program-level rejection from the in-critical-section rejection, rather than from 'the later check'? The wording reads as left over from the pre-unification code layout and may send a reader looking for a second call site that no longer exists. --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31921026518