Re: [PATCH bpf-next v1 02/14] selftests/bpf: Test verifier stack-read diagnostic attribution

[email protected]
Newsgroups org.kernel.vger.bpf
Message-ID <d7d6ffd97c2a82ff6fd69c784d944a8458586008c5f01469bdb81091b08fb01f@mail.kernel.org>
> selftests/bpf: Test verifier stack-read diagnostic attribution
>
> Verifier diagnostics distinguish uninitialized stack bytes from opaque
> dynptr, iterator, and IRQ-flag state, and identify variable-offset atomic
> stack accesses without changing the existing verbose messages.
>
> Add output assertions to the existing dynptr and iterator rejection
> cases. Add a direct IRQ-flag read and a variable-offset atomic stack
> access to cover the other classifications. Retain an assertion for the
> legacy helper-worded verbose message in the atomic test.
>
> Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]>

This isn't a bug, but would it be worth adding one assertion on the
retained uninitialized-stack-read report as well? The commit adds test
coverage for STACK_DYNPTR, STACK_ITER, STACK_IRQ_FLAG and the
variable-offset atomic path, but leaves the STACK_INVALID arm unpinned.
If a later refactor changes the uninitialized-read wording to reuse the
new verifier-managed state classification, the change would go unnoticed
in the test suite.


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31921026518
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.