Re: [PATCH net-next 0/5] selftests/xsk: improve shared-UMEM coverage and infrastructure

Daniel Borkmann <[email protected]>
Newsgroups org.kernel.vger.bpf,org.kernel.vger.netdev
Message-ID <[email protected]>
Hi Tushar,

On 8/7/26 3:42 PM, Tushar Vyavahare wrote:
> AF_XDP shared-UMEM support in existing XSK selftests is limited to a
> small set of scenarios and cleanup paths that become fragile as coverage
> expands.
> 
> This series improves shared-UMEM testing and infrastructure in five
> steps.
> 
> Patch 1 introduces explicit UMEM lifetime management with refcounting
> and consolidates socket/UMEM teardown into common helpers, keeping
> cleanup behavior consistent across normal completion and error paths.
> 
> Patch 2 adds rollback for partial socket setup in xsk_configure() when
> xsk_socket__create() retries are exhausted or busy-poll setup fails.
> 
> Patch 3 adds a length-based XDP steering helper and updates XSKMAP/test
> capacity constants for 4-socket scenarios. Steering is explicitly based
> on total XDP-visible packet length (data_end - data) using
> SHARED_UMEM_LEN_SPLIT.
> 
> Patch 4 adds the shared-UMEM callback runner together with the first
> four test cases (4-socket, length-based steering, uneven distribution,
> and unaligned chunk mode) in one commit so every SHA in the series
> builds and bisects cleanly. The unaligned path snapshots/restores prior
> alignment flags with NULL-safe UMEM guards.
> 
> Patch 5 makes pkt_stream_even_odd_sequence() rollback-safe by staging
> replacement streams in temporary arrays and committing only after all
> allocations succeed.
> 
> Together, these patches make shared-UMEM setup/cleanup more robust and
> extend selftest coverage to common multi-socket and distribution
> scenarios.
> 
> Signed-off-by: Magnus Karlsson <[email protected]>
> Signed-off-by: Tushar Vyavahare <[email protected]>
Looks like this needs a v2 respin based on the LLM reviews.

Thanks,
Daniel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.