Re: [PATCH net-next] bpf, xdp: move offload check into dev_xdp_install()
| Newsgroups | org.kernel.vger.bpf,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <178698783797.1666117.698643856348207432.git-patchwork-notify@kernel.org> |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>: On Wed, 12 Aug 2026 14:36:11 +0800 you wrote: > bpf_xdp_link_update() calls dev_xdp_install() directly and skips > dev_xdp_attach(), so the checks in dev_xdp_attach() do not run. A user can > make an XDP link with a normal program and then swap in an offloaded or > device-bound program with BPF_LINK_UPDATE, which puts it on the software > path. > > dev_xdp_install() is the one place all three paths go through: > "ip link set xdp" and BPF_LINK_CREATE reach it via dev_xdp_attach(), and > BPF_LINK_UPDATE calls it directly. So move the program checks (offloaded, > bound to another device, device-bound in generic mode, native vs generic, > DEVMAP and CPUMAP) there, and keep only the netlink-flag check > (XDP_FLAGS_UPDATE_IF_NOEXIST) in dev_xdp_attach(). > > [...] Here is the summary with links: - [net-next] bpf, xdp: move offload check into dev_xdp_install() https://git.kernel.org/netdev/net/c/ad27ed7d2309 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html