Re: [PATCH bpf-next v2] bpf: Fix stack out-of-bounds write in cgroup link update
Sanghyun Park <[email protected]>
| Newsgroups | org.kernel.vger.bpf,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Hello Leon, Thanks for the review. > Seems not a good choice to use 'bool check_cap_net_admin' here. > > Better to factor out a helper to check CAP_NET_ADMIN first? I tried to minimize the code changes and avoid introducing another helper, but it seems that your approach is cleaner than this version. Let me try that way in v3, thanks!