Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The target `avx_64` has its extra files dependency declared twice consecutively.
--
--- Patch [1]: [PATCH v3 1/5] selftests/x86: fix Makefile dependencies ---
commit d009708fbed1c85db2f909f2fe20cdcff1a21a01
Author: Bill Roberts <[email protected]>
selftests/x86: fix Makefile dependencies
This commit updates the x86 selftests Makefile to track dependencies for
compilation targets that use EXTRA_FILES. It uses the extra-files macro to
ensure these dependencies are correctly evaluated during the build.
> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index 434065215d127..a9a229f83b771 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -124,6 +124,10 @@ $(eval $(call extra-files,test_syscall_vdso_32,thunks_32.S))
> $(eval $(call extra-files,fsgsbase_restore_64,clang_helpers_64.S))
> $(eval $(call extra-files,fsgsbase_restore_32,clang_helpers_32.S))
> $(eval $(call extra-files,sysret_rip_64,clang_helpers_64.S))
> +$(eval $(call extra-files,amx_64,xstate.c))
> +$(eval $(call extra-files,avx_64,xstate.c))
> +$(eval $(call extra-files,avx_64,xstate.c))
[Severity: Low]
This isn't a bug, but is this duplicate declaration for avx_64 intentional?
> +$(eval $(call extra-files,apx_64,xstate.c))
>
> # check_initial_reg_state is special: it needs a custom entry, and it
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.