Re: [PATCH bpf-next v7 2/9] selftests/bpf: drop stale lines, restore two header dependencies

[email protected]
Newsgroups org.kernel.vger.bpf
Message-ID <baf68874e21b823ef6bef5bd2d9d8e5d8b487007b0ce6b9590c4a7bc20d88047@mail.kernel.org>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 118a7c356e26c..c7c7f27dd8605 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -4,9 +4,7 @@ include ../../../scripts/Makefile.arch
>  include ../../../scripts/Makefile.include
>
>  CXX ?= $(CROSS_COMPILE)g++
> -OBJCOPY ?= $(CROSS_COMPILE)objcopy
>
> -CURDIR := $(abspath .)
>  TOOLSDIR := $(abspath ../../..)

This isn't a bug, but would it be worth splitting the OBJCOPY and CURDIR
variable removals into their own small cleanup patch? The subject and the
bulk of the changelog focus on stale build rules and the two restored
header dependencies, while these variable removals are unused/redundant
definitions that get their own paragraph at the end.

[ ... ]


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/32662817569
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.