Re: [RFC PATCH bpf-next v3 1/2] ftrace: deprecate disabling via ftrace_enabled sysctl
Miroslav Benes <[email protected]>
| Newsgroups | org.kernel.vger.bpf,org.kernel.vger.linux-trace-kernel,org.kernel.vger.live-patching,org.kernel.vger.stable |
|---|---|
| Message-ID | <178757444126.29054.5684338666506602450.b4-reply@b4> |
On 2026-08-09 14:32:16-04:00, Andrey Grodzovsky wrote: > On Thu, Aug 6, 2026 at 5:52 PM Andrey Grodzovsky > <[email protected]> wrote: > > > On Thu, Aug 6, 2026 at 5:22 PM Song Liu <[email protected]> wrote: > > > > The bot has 2 comments. > > > > In my opinion, the test-breaking comment is wrong as he looked > > strictly at this patch w/o reviewing the follow-up live patch testing > > changes which update the tests to avoid breaks. > > > > The cleanup comment is valid but since we aren't sure if we'll need to > > revert this change later if it breaks userspace in some unseen way, I > > wonder how extensive the cleanup should be? Steven, can you advise > > please ? > > > > Andrey > > Gentle ping on this question above Steven. I am not Steven but I think we should wait with the cleanup exactly due to a possible revert. The same as for PERMANENT flag we talked about elsewhere.