Re: [PATCH v10 03/35] cachefiles,netfs: sunset ondemand mode

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Removal of the exported UAPI header `include/uapi/linux/cachefiles.h` breaks userspace compilation.
--

--- Patch [3]: [PATCH v10 03/35] cachefiles,netfs: sunset ondemand mode ---
commit eb4335001c5a2237f8379d09b27bb7484e9e516a
Author: Gao Xiang <[email protected]>

cachefiles,netfs: sunset ondemand mode

This commit removes the on-demand read mode from cachefiles, as EROFS
over fscache is no longer an in-tree user and fscache is now focused
on netfslib. It also cleans up the related netfs, fscache, and cachefiles
code paths.

Link: https://lore.kernel.org/r/CAOQ4uxi4dzxArY24YO=+kBCK2gGoq3Ptb8WkzCqSogPgU_R3dQ@mail.gmail.com
Link: https://sashiko.dev/#/patchset/20260716103030.3065561-1-dhowells%40redhat.com
Link: https://sashiko.dev/#/patchset/20260722130218.78958-1-dhowells%40redhat.com

[ ... ]

> diff --git a/include/uapi/linux/cachefiles.h b/include/uapi/linux/cachefiles.h
> deleted file mode 100644
> index 78caa73e53434..0000000000000
> --- a/include/uapi/linux/cachefiles.h
> +++ /dev/null
> @@ -1,68 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _LINUX_CACHEFILES_H
> -#define _LINUX_CACHEFILES_H
> -
> -#include <linux/types.h>
> -#include <linux/ioctl.h>

[Severity: Critical]
Does removing this exported header break source-level compatibility for
userspace applications? Any program or container runtime that includes
<linux/cachefiles.h> will now encounter a file not found compilation
error when built against these updated kernel headers.

Should the UAPI header and its definitions be kept intact so userspace
builds continue to succeed, while instead just returning errors like
-EOPNOTSUPP from the kernel for these legacy ioctls and operations?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3