Re: [PATCH 04/12] fs/ceph/super.h: convert ceph_inode_xattr fields to `bool`

Viacheslav Dubeyko <[email protected]>
Newsgroups org.kernel.vger.ceph-devel,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Fri, 2026-06-12 at 18:51 +0200, Max Kellermann wrote:
> This reduces the size of `struct ceph_inode_xattr` by 8 bytes.
> 
> Signed-off-by: Max Kellermann <[email protected]>
> ---
>  fs/ceph/super.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index f0f03aeb5b19..18960a9e735a 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -318,10 +318,10 @@ struct ceph_inode_xattr {
>  	int name_len;
>  	const char *val;
>  	int val_len;
> -	int dirty;
> +	bool dirty;
>  
> -	int should_free_name;
> -	int should_free_val;
> +	bool should_free_name;
> +	bool should_free_val;
>  };
>  
>  /*

To use the bool instead of int data type looks good.

Reviewed-by: Viacheslav Dubeyko <[email protected]>

Thanks,
Slava.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.