Re: [RFC/BUG] Use a bounce buffer for mds client decryption

Alex Markuze <[email protected]> Thu, 2 Jul 2026 11:40:26 +0000

Newsgroups	org.kernel.vger.ceph-devel
Message-ID	<[email protected]>

Hi Sam,

NACK for now. Thanks for the patch, but I have some concerns
that need a v2:

  1. [major] fs/ceph/mds_client.c:578: BUG_ON on wire-controlled length panics the client
  2. [major] fs/ceph/mds_client.c:580: Patch may not build against current tree
  3. [major] fs/ceph/inode.c: Trace/LOOKUPNAME path has the same vmalloc/fscrypt bug
  4. [minor] fs/ceph/mds_client.c:497: Assignment-in-if and missing braces
  5. [nit] fs/ceph/mds_client.c:494: Typo: fscript_str → fscrypt_str
  6. [nit] fs/ceph/mds_client.c:574: Missing unlikely() on inner-loop bounce check


-- 
Alex Markuze