Re: ceph: fix denial of service issue in ceph_update_snap_trace()
Viacheslav Dubeyko <[email protected]>
| Newsgroups | org.kernel.vger.ceph-devel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 2026-06-30 at 17:50 +0000, Alex Markuze wrote:
> Hi Slava,
>
> This looks like the right direction to me, but I have a couple of comments.
>
> The Fixes tag seems to point at the later debug-log formatting change. The
> WARN/remount path looks like it was introduced by:
>
> a68e564adcaa ("ceph: blocklist the kclient when receiving corrupted snap trace")
>
> so I think that is the better Fixes target.
>
> Also, since `cl` is already in scope here, could you use
> `pr_warn_ratelimited_client()` instead of open-coding the `[client.%lld]`
> prefix? That keeps the log format consistent with the adjacent
> `pr_err_client()` and preserves the fsid in the message.
Yes, I can rework the patch. Let me spend some time on this.
Thanks,
Slava.