Re: [PATCH 1/1] libceph: use RCU to protect monmap in ceph_compare_options()

在 2026/7/14 6:22, Viacheslav Dubeyko 写道:
>>>> So it is safe to use.
>>>>
>>>>> Have you tried to run xfstests for the patch?
>>>> I ran the ceph xfstests in QEMU on the patched kernel, and all
>>>> ceph-
>>>> specific tests in the current tree passed: ceph/001-006.
>>>>
>>>>
>>> The running only Ceph specific test-cases is not enough. The patch
>>> should
>>> survive the auto group of xfstests.
>>>
>> I reran the tests on a baseline kernel before the RCU patch.
>>
>> Excluding the notrun cases, the following tests failed both before
>> and after the patch:
>>
>> - generic/363: fsx reported READ BAD DATA
>> - generic/429: encrypted dentry/key revalidation behavior did not
>> match expectations
>> - generic/440: encrypted name/key cache consistency behavior did not
>> match expectations
>> - generic/580: encrypted files became inaccessible after key
>> removal/re-addition
>> - generic/593: filesystem-level/provisioning-key encryption flow
>> failed
>> - generic/595: encrypted file remained inaccessible after key
>> eviction/re-addition
>> - generic/631: overlayfs-on-Ceph scratch mount path failed
>>
>> generic/650 and generic/777 could not be completed reliably in my
>> local environment because 
>> they caused the terminal to become unresponsive, so I do not have a
>> meaningful 
>> before/after comparison for them.
>>
>> So from this comparison, I do not have evidence that the above
>> failures were introduced 
>> by the RCU patch.
>>
>> Kernel(net) commit tested before the patch:
>>   6d27e29a90bc6a717b97c6ddcd866db7bd8e4adc
>>
>> xfstests commit:
>>   ffc8bad17e5b2f56e48dbac43f7c5ae8ac368fe5
>>
>>
> It's interesting that you can reproduce more failures that I can
> reproduce in my environment. 🙂 Usually, I can see around 3 failed
> xfstests. I've already shared fixes for several ones. But my fixes
> haven't been accepted. We still need to fix some xfstests failures. 🙂
> 
> The patch makes sense to me and it looks good.
> 
> Reviewed-by: Viacheslav Dubeyko <[email protected]>
> 
> Thanks,
> Slava.
Hi Slava,

Thank you for your review.

This patch has been sitting for quite a while, so I wanted to politely
check whether there has been any progress on it, or if there is anything
more I should do on my side to help move it forward.

Best regards,
Yong