Re: [PATCH v4 08/14] nvme-pci: implement dma_token backed requests
Christoph Hellwig <[email protected]> Wed, 29 Jul 2026 09:10:48 +0200
| Newsgroups | org.kernel.vger.ceph-devel,dev.linux.lists.dm-devel,dev.linux.lists.nvdimm,org.infradead.lists.linux-nvme,org.kernel.vger.io-uring,org.kernel.vger.linux-block,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
> +static int nvme_init_dma_buf_io_ctx(struct block_device *bdev, > + struct dma_buf_io_ctx *ctx) Please stick to two-tab indents for function declaration continuation for the nvme code to keep the code easy to maintain. > +#if defined(CONFIG_DMA_SHARED_BUFFER) This should be good old #ifdef. Same in a few other places over the series. Modulo these minor nits the patch looks good.