Re: [PATCH] ceph: force a cap message when a deferred revoke can't be acked immediately

Hi Max,

There's a bug in the new clear_bit() call in ceph_check_caps() —
clear_bit(CEPH_I_FLUSH_FORCE, &ci->i_ceph_flags) passes the mask
(1 << 15 = 32768) as the bit number instead of the bit index.
clear_bit() expects a bit index, so with nr=32768 the kernel writes
4 KiB past i_ceph_flags, corrupting unrelated memory. The line
directly above shows the correct pattern: clear_bit(CEPH_I_FLUSH_BIT, ...).

Should be clear_bit(CEPH_I_FLUSH_FORCE_BIT, &ci->i_ceph_flags).

Could you respin with that fix?

--
Alex Markuze