Re: [PATCH v2 2/2] libceph: add KUnit coverage for OSD sparse-read extent validation
Alex Markuze <[email protected]>
| Newsgroups | org.kernel.vger.ceph-devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Michael, A few issues with the test code: The test suite leaks the page allocated in osd_sparse_read_test_init() when an early assertion fails before cleanup runs. The insert_request() and erase_request() calls in the test body also lack the locking that the production code requires around them. Also, Slava raised a concern about the KUnit integration approach that hasn't been addressed — please make sure that's resolved before v3. Could you respin? -- Alex Markuze