Re: fs/ceph/super: document struct ceph_dentry_info and its flags
Max Kellermann <[email protected]>
| Newsgroups | org.kernel.vger.ceph-devel |
|---|---|
| Message-ID | <CAKPOu+946t8E6b6U0UtyqddoU869-tNg96BkytCa2MOsB6QsuA@mail.gmail.com> |
On Tue, Aug 11, 2026 at 4:25 PM Alex Markuze <[email protected]> wrote: > 1. [minor] fs/ceph/super.h:440: CEPH_DENTRY_REFERENCED comment is too narrow [...] > 2. [minor] fs/ceph/super.h:422: time field comment says last touched but is insertion/requeue timestamp I don't understand, please explain. The "time" field is only ever updated here: - ceph_d_init(): initialization after object is created - __dentry_dir_lease_touch(): I documented this as "last touched" - ceph_invalidate_dentry_lease(): preparing for destruction None of these insert or requeue the object anywhere, do they? What does "insertion"/"requeue" even mean here? > 3. [nit] fs/ceph/super.h:399: lease_seq comment says REVOKE but client sends REVOKE_ACK I have fixed 1. and 3. in patch v2. -- Max Kellermann Principal Architect Hosting Technology cm4all | Im Mediapark 6a | 50670 Köln | Germany General information about the company can be found here: https://www.cm4all.com/impressum A member of the IONOS Group