Re: [PATCH] mm: memcg-v1: fix wrong linux-mm list address in deprecation warnings

Michal Hocko <[email protected]>
Newsgroups org.kernel.vger.cgroups,org.kernel.vger.linux-kernel,org.kvack.linux-mm
Message-ID <alS4v5spUF224idW@tiehlicka>
On Mon 13-07-26 16:57:56, Guopeng Zhang wrote:
> From: Guopeng Zhang <[email protected]>
> 
> The deprecation warnings for memory.oom_control and
> memory.pressure_level use [email protected] instead of the linux-mm
> mailing list address. Remove the extra hyphen.
> 
> Signed-off-by: Guopeng Zhang <[email protected]>

Acked-by: Michal Hocko <[email protected]>
Thanks

Altohough this is not a critical fix we would like to have that address
correct also in older stable trees so I would recommend backporting to
stable as well.

> ---
>  mm/memcontrol-v1.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c
> index e8b6e1560278..178e1466d898 100644
> --- a/mm/memcontrol-v1.c
> +++ b/mm/memcontrol-v1.c
> @@ -1182,13 +1182,13 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of,
>  		event->unregister_event = mem_cgroup_usage_unregister_event;
>  	} else if (!strcmp(name, "memory.oom_control")) {
>  		pr_warn_once("oom_control is deprecated and will be removed. "
> -			     "Please report your usecase to [email protected]"
> +			     "Please report your usecase to [email protected]"
>  			     " if you depend on this functionality.\n");
>  		event->register_event = mem_cgroup_oom_register_event;
>  		event->unregister_event = mem_cgroup_oom_unregister_event;
>  	} else if (!strcmp(name, "memory.pressure_level")) {
>  		pr_warn_once("pressure_level is deprecated and will be removed. "
> -			     "Please report your usecase to [email protected] "
> +			     "Please report your usecase to [email protected] "
>  			     "if you depend on this functionality.\n");
>  		event->register_event = vmpressure_register_event;
>  		event->unregister_event = vmpressure_unregister_event;
> @@ -2340,7 +2340,7 @@ static int mem_cgroup_oom_control_write(struct cgroup_subsys_state *css,
>  	struct mem_cgroup *memcg = mem_cgroup_from_css(css);
>  
>  	pr_warn_once("oom_control is deprecated and will be removed. "
> -		     "Please report your usecase to [email protected] if you "
> +		     "Please report your usecase to [email protected] if you "
>  		     "depend on this functionality.\n");
>  
>  	/* cannot set to root cgroup and only 0 and 1 are allowed */
> -- 
> 2.43.0
> 

-- 
Michal Hocko
SUSE Labs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.