[PATCH v2 00/13] mm/slab, alloc_tag: reduce obj_ext memory waste
"Vlastimil Babka (SUSE)" <[email protected]>
| Newsgroups | org.kernel.vger.cgroups,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
The recent fixes for objext array handling inspired me to look into this finally. It's been bothering me that the memory usage of struct slabobj_ext depend only on config options and not whether the fields are actually used. So with both CONFIG_MEMCG=y and CONFIG_MEM_ALLOC_PROFILING=y there is always objcg field and codetag_ref field. And thus: 1) Having memory allocation profiling config-enabled but not boot-enabled means wasted memory on unused codetag_refs. This makes it less suitable for a general distro config and the page allocator side doesn't suffer from this, only slab and percpu. 2) Complementary, with memory allocation profiling enabled, there are caches/slabs that don't need the objcg field, so memory is wasted on those. This series should solve the point 1) fully for slab, pcpuobj_ext handling can be perhaps improved similarly, haven't looked into that. For 2) it avoids allocating objcg fields for KMALLOC_NORMAL caches where we know they are not necessary because kmalloc() with __GFP_ACCOUNT will pick a KMALLOC_CGROUP type. The named kmem_caches are tricky. They can be created with SLAB_ACCOUNT and then we know objcg fields are always needed. But also they can be created without SLAB_ACCOUNT and then some allocations have __GFP_ACCOUNT and some not and we don't know that in advance. This series introduces a SLAB_MAY_ACCOUNT flag that's currently internal only and is applied to all caches (unless kmem accounting is disabled) except KMALLOC_NORMAL (unless that aliases KMALLOC_RECLAIM). As a followup we can make SLAB_MAY_ACCOUNT explicit and add it to to caches where we know __GFP_ACCOUNT is used. Then we could only honour __GFP_ACCOUNT for those, while warning for an unexpected usage elsewhere. Only lightly tested, need to run at least some microbenchmarks to see if the now somewhat more complicated access to objcg is visible or not. Based on slab/for-next-fixes Git branch: https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=b4/objext_split Signed-off-by: Vlastimil Babka (SUSE) <[email protected]> --- Changes in v2: - Apply Suren's R-b:, thanks! - Expanded explanation about no longer accounting KFENCE objects (Suren) - Also skip them in in mark_obj_codetag_empty() (sashiko) - Update slab_obj_ext() comments (sashiko) - Separate slab_obj_ext_objcg() and slab_obj_ext_set_objcg() (Suren) - Add SLAB_MAY_ACCOUNT internal flag instead of relying on is_kmalloc_normal(); also handle mem_cgroup_kmem_disabled() - Also fix the SLUB_TINY kmalloc aliasing handling, per Harry. - Link to v1: https://patch.msgid.link/[email protected] --- Vlastimil Babka (SUSE) (13): mm/slab: skip kfence objects in allocation profiling mm/slub: skip handle_failed_objexts_alloc() with profiling disabled mm/slab: remove objs_per_slab() mm: move struct slabobj_ext to mm/slab.h mm/slab: make slab_obj_ext() determine object index mm/slab: abstract slabobj_ext.objcg access mm/slab: abstract slabobj_ext.ref access mm/slab: replace slab.stride with obj_exts_in_object mm/slab: change struct slabobj_ext to a union mm/slab: introduce slab_obj_ext_has_codetag() mm/slab: reduce slabobj_ext memory with allocation profiling disabled mm/slab: add cache_ and slab_needs_objcg() helpers mm/slab: stop allocating objcg pointers when unnecessary Documentation/mm/allocation-profiling.rst | 7 ++ include/linux/memcontrol.h | 13 --- include/linux/slab.h | 3 + mm/kfence/core.c | 5 +- mm/kfence/kfence_test.c | 2 +- mm/memcontrol.c | 32 +++--- mm/slab.h | 185 ++++++++++++++++++++++++------ mm/slab_common.c | 25 +++- mm/slub.c | 173 ++++++++++++++++++---------- 9 files changed, 314 insertions(+), 131 deletions(-) --- base-commit: d9e6a7623938968e3752b67e37eaff097e559a54 change-id: 20260714-b4-objext_split-da82426257d5