Re: [PATCH] blk-cgroup: remove unused blk_queue_for_each_rl stub
"yu kuai" <[email protected]> Thu, 23 Jul 2026 14:47:21 +0800
| Newsgroups | org.kernel.vger.cgroups,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
在 2026/7/17 18:20, Tao Cui 写道: > From: Tao Cui<[email protected]> > > blk_queue_for_each_rl() was added by commit a051661ca6d1 ("blkcg: > implement per-blkg request allocation") to iterate over the root request > list and per-blkg request lists for the legacy (non-blk-mq) request > allocation path. The request_list code, including q->root_rl from > struct request_queue, was later removed in 2018 by commit db6d99523560 > ("block: remove request_list code"). > > The macro definition left behind in the !CONFIG_BLK_CGROUP fallback > branch of the private block/blk-cgroup.h header now references the > removed q->root_rl field, and has no callers in-tree (it would fail to > compile if expanded, so it cannot have any out-of-tree users either). > > Remove the dead stub. > > Signed-off-by: Tao Cui<[email protected]> > --- > block/blk-cgroup.h | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Yu Kuai <[email protected]> -- Thanks, Kuai