Re: [PATCH v3 07/13] mm/slab: replace slab.stride with obj_exts_in_object
Harry Yoo <[email protected]> Wed, 29 Jul 2026 06:40:57 +0000
| Newsgroups | org.kernel.vger.cgroups,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <ammbWxBtX7KxgJ5R@dev> |
On Mon, Jul 27, 2026 at 02:54:01PM +0200, Vlastimil Babka (SUSE) wrote: > The stride field is used to convert object index to an slabobj_ext so > both compact arrays (kmalloc() or in-slab-leftover) and spread > in-object-padding obj_ext layouts are supported. > > In practice thus the stride is always sizeof(slabobj_ext) or s->size. > > This simplifies the calculations, but with the upcoming slabobj_ext > handling changes, it will be easier to stop storing the stride and > instead just have a flag whether obj_ext is in the object padding. > obj_exts_in_object() can then rely on this flag and slab_obj_ext() > can use that to determine the stride. > > No functional change intended. Performance impact TBD, hopefully > in the noise. Performance impact is not TBD anymore? > Reviewed-by: Suren Baghdasaryan <[email protected]> > Reviewed-by: Hao Li <[email protected]> > Signed-off-by: Vlastimil Babka (SUSE) <[email protected]> > --- Looks good to me, Reviewed-by: Harry Yoo (Oracle) <[email protected]>