Re: [PATCH 2/2] selftests/cgroup: write explicit period to cpu.max in max tests

--piybutfk75vjrsrz
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Subject: Re: [PATCH 2/2] selftests/cgroup: write explicit period to cpu.max
 in max tests
MIME-Version: 1.0

Hi.

Here I cannot appreciate the changes.

On Wed, Jul 29, 2026 at 06:04:51PM +0800, Shaojie Sun <[email protected]> wrote:
> The cpu.max interface accepts "quota period" as two values, but
> test_cpucg_max and test_cpucg_max_nested only wrote the quota,
> relying on the kernel default period of 100ms.

Yes. Is that a problem?

> Write both values explicitly so that the period can be easily
> adjusted for testing purposes and the remainder logic becomes
> genuinely useful.

I have yet to see a system where the default period is modified.
Therefore, I wouldn't open that box with non-default periods
unnecessarily.

Thanks,
Michal

--piybutfk75vjrsrz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCamnpnhsUgAAAAAAEAA5t
YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+Ail5gD/fGsAYBJwbk2uztBZqwSE
MMwWF6gfM7FfiSKb+4t7vcgBALL32jYxI+iP0Qwr9ps5a9eA/iQFxErZIKHCIWeF
r4sG
=8BAZ
-----END PGP SIGNATURE-----

--piybutfk75vjrsrz--