Re: [PATCH v2] mm: memcg-v1: fix memsw and TCP failcnt accounting

On Tue, Aug 11, 2026 at 11:08:43AM +0800, Guopeng Zhang wrote:
> From: Guopeng Zhang <[email protected]>
> 
> Commit 0e2759afcaf9 ("page_counter: track failcnt only for legacy
> cgroups") made failcnt accounting conditional on track_failcnt. It
> enabled the flag for memcg->memory, but not for memcg->memsw or
> memcg->tcpmem.
> 
> Consequently, memory.memsw.failcnt remains zero when the memory+swap
> limit is hit. memory.kmem.tcp.limit_in_bytes still sets
> memcg->tcpmem.max, but TCP charge failures are not reflected in
> memory.kmem.tcp.failcnt.
> 
> Enable failcnt accounting for both v1 counters.
> 
> To reproduce memory.memsw.failcnt:
> 
>     CG=/sys/fs/cgroup/memory/memsw-test
>     LIMIT=33554432
>     mkdir "$CG"
>     echo "$LIMIT" > "$CG/memory.limit_in_bytes"
>     echo "$LIMIT" > "$CG/memory.memsw.limit_in_bytes"
> 
> Start a child process in the cgroup and make it allocate and touch 96 MiB
> of memory, causing a memcg OOM.
> 
>     cat "$CG/memory.memsw.failcnt"
> 
> Without the patch, memory.memsw.failcnt is 0. With the patch,
> memory.memsw.failcnt is greater than 0.
> 
> To reproduce memory.kmem.tcp.failcnt:
> 
>     CG=/sys/fs/cgroup/memory/tcpmem-test
>     LIMIT=65536
>     mkdir "$CG"
>     echo "$LIMIT" > "$CG/memory.kmem.tcp.limit_in_bytes"
> 
> Start a child process in the cgroup, create a TCP socket, and reserve
> 1 MiB of socket memory with SO_RESERVE_MEM. The reservation fails with
> ENOMEM.
> 
>     cat "$CG/memory.kmem.tcp.failcnt"
> 
> Without the patch, memory.kmem.tcp.failcnt is 0. With the patch,
> memory.kmem.tcp.failcnt is greater than 0.
> 
> Closes: https://sashiko.dev/#/patchset/[email protected]?part=1
> Fixes: 0e2759afcaf9 ("page_counter: track failcnt only for legacy cgroups")
> Cc: [email protected]
> Acked-by: Johannes Weiner <[email protected]>
> Acked-by: Michal Hocko <[email protected]>
> Signed-off-by: Guopeng Zhang <[email protected]>

Acked-by: Shakeel Butt <[email protected]>