Re: [PATCH 4/9] memcg: remove the soft limit reclaim tracepoints
Michal Hocko <[email protected]>
| Newsgroups | org.kernel.vger.cgroups,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <an1_amxUpeVU_ARo@tiehlicka> |
On Tue 11-08-26 13:31:58, Shakeel Butt wrote: > mm_vmscan_memcg_softlimit_reclaim_begin and > mm_vmscan_memcg_softlimit_reclaim_end were only emitted by > mem_cgroup_shrink_node(), which is gone, so they can never fire again. > > Signed-off-by: Shakeel Butt <[email protected]> Acked-by: Michal Hocko <[email protected]> Thanks! > --- > include/trace/events/vmscan.h | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > index b4bf7b8def1f..8a872990b4be 100644 > --- a/include/trace/events/vmscan.h > +++ b/include/trace/events/vmscan.h > @@ -214,13 +214,6 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_reclaim_be > > TP_ARGS(gfp_flags, order, memcg) > ); > - > -DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_softlimit_reclaim_begin, > - > - TP_PROTO(gfp_t gfp_flags, int order, struct mem_cgroup *memcg), > - > - TP_ARGS(gfp_flags, order, memcg) > -); > #endif /* CONFIG_MEMCG */ > > DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_end_template, > @@ -260,13 +253,6 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_reclaim_end, > > TP_ARGS(nr_reclaimed, memcg) > ); > - > -DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_reclaim_end, > - > - TP_PROTO(unsigned long nr_reclaimed, struct mem_cgroup *memcg), > - > - TP_ARGS(nr_reclaimed, memcg) > -); > #endif /* CONFIG_MEMCG */ > > TRACE_EVENT(mm_shrink_slab_start, > -- > 2.53.0-Meta -- Michal Hocko SUSE Labs