Re: [PATCH] selftests/cgroup: Fix cg_run_in_subcgroups ignoring arg parameter
Michal Koutný <[email protected]>
| Newsgroups | org.kernel.vger.cgroups,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 20, 2026 at 03:09:44PM +0800, Hongfu Li <[email protected]> wrote: > From: Hongfu Li <[email protected]> > > cg_run_in_subcgroups() discards its arg and always passes NULL to cg_run(), > turning the (void *)100 from test_kmem_dead_cgroups() into NULL so no > allocation occurs. > > This makes test_kmem_dead_cgroups() falsely pass without exercising the > "dying cgroup with charged slab" scenario it intends to test. > > Pass the arg through to cg_run() to fix this. > > Fixes: 933dc80ec262 ("kselftests: cgroup: add kernel memory accounting tests") > Signed-off-by: Hongfu Li <[email protected]> > --- > tools/testing/selftests/cgroup/test_kmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Good catch, Reviewed-by: Michal Koutný <[email protected]>
signature.asc
(application/pgp-signature, 265 B)
-----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCaobIcxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AjWhwEAka0wkR1ajkCSVyjaiXDA XIVViX0NbgRoaisxbd3m6XYA/0av7r0/ssp0z/21d6p1a6x5TWOMouSsQwmWbet+ y5YG =RIxv -----END PGP SIGNATURE-----