Re: [PATCH] Simplify alias storage.
Herbert Xu <[email protected]>
| Newsgroups | org.kernel.vger.dash |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jan 11, 2023 at 06:23:41PM +0000, Harald van Dijk wrote:
>
> if (ap) {
> if (!(ap->flag & ALIASINUSE)) {
> - ckfree(ap->val);
> + ckfree(ap->name);
> }
I think this breaks ALIASINUSE. When an alias is marked as INUSE,
it will be freed by input.c (popstring). However, your patch doesn't
touch input.c at all.
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt