[PATCH] jobs: Add comment about reset_input in forkchild

Herbert Xu <[email protected]>
Newsgroups org.kernel.vger.dash
Message-ID <[email protected]>
For background jobs where the stdin is redirected to /dev/null,
a reset_input may be needed in future.  For the time being there
is no reason to do this as all possible states for stdin will work
correctly with /dev/null.

Signed-off-by: Herbert Xu <[email protected]>
---
 src/jobs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/jobs.c b/src/jobs.c
index 247fab5..51e6fa1 100644
--- a/src/jobs.c
+++ b/src/jobs.c
@@ -904,6 +904,9 @@ static void forkchild(struct job *jp, union node *n, int mode)
 		if (jp->nprocs == 0) {
 			close(0);
 			sh_open(_PATH_DEVNULL, O_RDONLY, 0);
+			/* Should call reset_input here, but it's harmless
+			 * for now.
+			 */
 		}
 	}
 	if (!oldlvl && iflag) {
-- 
2.39.2

-- 
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.