Re: [PATCH] histedit: fix dash exiting when receiving a signal interactively

On Thu, Sep 18, 2025 at 10:45:38PM +0300, 3bd wrote:
>
> EditLine has no "restore the current line to XYZ".
> No el_restore_line() or something similar.
> 
> We could avoid this if we set the SA_RESTART flag in sa_flags,
> then EditLine's internal call to read(2) won't fail.
> But I'm not sure about this. This could play with dash's internal
> handling of signals.

I think that's a defiency in libedit and should be addressed there.

> >> -       if (signo == SIGCHLD)
> >> +       if (
> >> +               signo == SIGCHLD
> >> +#if defined(WINCH) && !defined(SMALL)
> >> +               || signo == WINCH
> >> +#endif
> >
> > Please use SIGWINCH consistently.
> 
> Oh, sorry, I just noticed the mistake.

I'm happy to take the SIGWINCH change though.

Thanks,
-- 
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt