Re: Unreachable code in evalsubshell()?

Denys Vlasenko <[email protected]> Tue, 27 Jan 2026 16:22:36 +0100

Newsgroups	org.kernel.vger.dash
Message-ID	<CAK1hOcMxctsmA_K3QiP4OuYchwMezaNBOQcv8F6oxfEd0dhGwg@mail.gmail.com>

On Tue, Jan 27, 2026 at 8:49 AM Harald van Dijk <[email protected]> wrote:
> On 27/01/2026 04:26, Denys Vlasenko wrote:
> >          switch (n->type) {
> > ...
> >          case NBACKGND:
> >                  evalfn = evalsubshell;  //THIS IS THE ONLY USE OF evalsubshell
> >                  goto checkexit;
> > ...
>
> The last line of that first ... is rather relevant though:
>
>          case NSUBSHELL:
>          case NBACKGND:
>                  evalfn = evalsubshell;
>                  goto checkexit;
>
> evalsubshell may be called for NSUBSHELL and for NBACKGND.

AHA. Thank you, I did not notice that!