Re: [PATCH v2] net: dccp: Checksum verification enhancement
David Miller <[email protected]>
| Newsgroups | org.kernel.vger.dccp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
From: <[email protected]> Date: Tue, 26 Mar 2019 08:54:41 +0000 > Modify checksum verification to allow the validation of skb->ip_summed, in case the checksum has already been verified in lower layers. Please format your commit message to ~80 column lines. > @@ -763,8 +763,9 @@ int dccp_invalid_packet(struct sk_buff *skb) > } > > /* If header checksum is incorrect, drop packet and return. > - * (This step is completed in the AF-dependent functions.) */ > - skb->csum = skb_checksum(skb, 0, cscov, 0); > + * (This step is completed in the AF-dependent functions.) > + * skb->csum = skb_checksum(skb, 0, cscov, 0); > + */ Please do not just comment out code, explain what is operation can be expected to be done already here and why.