Re: [PATCH v3] net: dccp: Checksum verification enhancement
David Miller <[email protected]>
| Newsgroups | org.kernel.vger.dccp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
From: <[email protected]> Date: Tue, 30 Apr 2019 16:11:07 +0000 > The current patch modifies the checksum verification of a received DCCP > packet, by adding the function __skb_checksum_validate into the > dccp_vX_rcv routine. The purpose of the modification is to allow the > verification of the skb->ip_summed flags during the checksum validation > process (for checksum offload purposes). As __skb_checksum_validate > covers the functionalities of skb_checksum and dccp_vX_csum_finish they > are needless and therefore removed. > > Signed-off-by: Nathalie Romo Moreno <[email protected]> > Signed-off-by: Markus Amend <[email protected]> I don't see how this can be correct as you're not taking the csum coverage value into consideration at all.