[PATCH v2 0/2] tcp/dcpp: tw_timer tweaks for nohz_full and PREEMPT_RT
Valentin Schneider <[email protected]> Wed, 15 Nov 2023 16:05:07 -0500
| Newsgroups | org.kernel.vger.dccp,org.kernel.vger.linux-kernel,org.kernel.vger.linux-rt-users,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
Hi, This is v2 of [1] where the tw_timer is un-pinned to get rid of interferences in isolated CPUs setups. Patch 1 is pretty much the same as v1, just got an extra comment in inet_twsk_deschedule_put() to highlight the race. Patch 2 was added as AFAICT the bh_disable is no longer needed after patch 1, and Sebastian mentioned during LPC the he had been looking at getting rid of it for removing softirq_ctrl.lock in PREEMPT_RT. Eric mentionned rsk_timer needs looking into, but I haven't had the time to do that. It doesn't show up in our testing, which might be due to its relatively low timeout (IIUC 3s). [1]: https://lore.kernel.org/all/[email protected]/ Valentin Schneider (2): tcp/dcpp: Un-pin tw_timer tcp/dcpp: Don't disable bh around timewait_sock initialization net/dccp/minisocks.c | 14 ++++---------- net/ipv4/inet_timewait_sock.c | 20 +++++++++++++++----- net/ipv4/tcp_minisocks.c | 14 ++++---------- 3 files changed, 23 insertions(+), 25 deletions(-) -- 2.41.0