Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel elements from ctl_table array

Joel Granados <[email protected]> Tue, 16 Apr 2024 14:32:12 +0200

Newsgroups	org.kernel.vger.dccp,dev.linux.lists.bridge,dev.linux.lists.mptcp,org.kernel.vger.linux-hams,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-rdma,org.kernel.vger.linux-s390,org.kernel.vger.linux-sctp,org.kernel.vger.linux-wpan,org.kernel.vger.linux-x25,org.kernel.vger.lvs-devel,org.kernel.vger.netdev,org.kernel.vger.netfilter-devel
Message-ID	<[email protected]>

On Tue, Apr 16, 2024 at 10:18:42AM +0200, Paolo Abeni wrote:
> On Mon, 2024-04-15 at 16:12 -0700, Kuniyuki Iwashima wrote:
> > From: Joel Granados via B4 Relay <[email protected]>
> > Date: Fri, 12 Apr 2024 16:48:29 +0200
> > > From: Joel Granados <[email protected]>
...
> > >  net/rxrpc/sysctl.c                  | 1 -
> > >  net/sctp/sysctl.c                   | 6 +-----
> > >  net/smc/smc_sysctl.c                | 1 -
> > >  net/sunrpc/sysctl.c                 | 1 -
> > >  net/sunrpc/xprtrdma/svc_rdma.c      | 1 -
> > >  net/sunrpc/xprtrdma/transport.c     | 1 -
> > >  net/sunrpc/xprtsock.c               | 1 -
> > >  net/tipc/sysctl.c                   | 1 -
> > >  net/unix/sysctl_net_unix.c          | 1 -
> > >  net/x25/sysctl_net_x25.c            | 1 -
> > >  net/xfrm/xfrm_sysctl.c              | 5 +----
> > >  35 files changed, 20 insertions(+), 81 deletions(-)
> > 
> > You may want to split patch based on subsystem or the type of changes
> > to make review easier.
> 
> I agree with Kuniyuki. I think the x25 chunks can me moved in the last
> patch, and at least sunrpc and rds could go in separate patches,
> possibly even xfrm and smc.

No problem. I'll put x25 and ax.25 patches together into one commit.
Thx

Best

-- 

Joel Granados

signature.asc (application/pgp-signature, 659 B)