Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code
Hongbo Li <[email protected]> Mon, 26 Aug 2024 09:41:17 +0800
| Newsgroups | org.kernel.vger.dccp,org.kernel.vger.linux-wireless,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 2024/8/24 20:06, David Howells wrote: > Hongbo Li <[email protected]> wrote: > >> - summary.ack_reason = (sp->ack.reason < RXRPC_ACK__INVALID ? >> - sp->ack.reason : RXRPC_ACK__INVALID); >> + summary.ack_reason = min(sp->ack.reason, RXRPC_ACK__INVALID); > > Can you use umin() rather than min(), please? > I see reason is u8, may I use min_t(u8, sp->ack.reason, RXRPC_ACK__INVALID); Thanks, Hongbo > Thanks, > David > >