Re: [PATCH net-next 7/8] net/rxrpc: Use min() to simplify the code

David Howells <[email protected]> Wed, 28 Aug 2024 09:17:57 +0100

Newsgroups	org.kernel.vger.dccp,org.kernel.vger.linux-wireless,org.kernel.vger.netdev
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
Message-ID	<[email protected]>

Hongbo Li <[email protected]> wrote:

> I see reason is u8, so may I use min_t(u8, sp->ack.reason,
> RXRPC_ACK__INVALID)?

No, please don't use min_t(<unsigned type>, ...) if umin() will do.  IIRC,
some arches can't do byte-level arithmetic.

Thanks,
David