Re: [PATCH] checks: Warn about missing #address-cells for interrupt parents

David Gibson <[email protected]> Wed, 18 Dec 2024 16:07:35 +1100

Newsgroups	org.kernel.vger.devicetree-compiler
Message-ID	<Z2JYlybB2TditOhj@zatzit>

On Mon, Dec 16, 2024 at 01:37:01PM -0600, Rob Herring wrote:
> On Fri, Dec 13, 2024 at 8:14 AM Thierry Reding <[email protected]> wrote:
> >
> > From: Thierry Reding <[email protected]>
> >
> > The device tree specification (v0.4) suggests that #address-cells is
> > mandatory for interrupt parent nodes. If this property is missing, Linux
> > will default to the value of 0.
> >
> > A number of device tree files rely on Linux' fallback and don't specify
> > an explicit #address-cells as suggested by the specification. This can
> > cause issues when these device trees are passed to software with a more
> > pedantic interpretation of the DT spec.
> >
> > Add a warning when this case is detected so that device tree files can
> > be fixed.
> >
> > Reported-by: Brad Griffis <[email protected]>
> > Signed-off-by: Thierry Reding <[email protected]>
> > ---
> > Applying this to Linux' copy reports on the order of 1300 issues that
> > originate from 29 .dtsi files. If this proposal is acceptable/useful, I
> > volunteer to patch those up so we don't get spammed by them.
> 
> I could have sworn I did a check for this, but it seems not.
> 
> > ---
> >  checks.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> 
> Reviewed-by: Rob Herring (Arm) <[email protected]>

Makes sense to me.  Applied.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

signature.asc (application/pgp-signature, 833 B)