Re: [PATCH] meson: don't build test programs by default

David Gibson <[email protected]> Mon, 3 Mar 2025 12:56:13 +1100

Newsgroups	org.kernel.vger.devicetree-compiler
Message-ID	<Z8UMPUk9h5ieMWr0@zatzit>

On Sun, Mar 02, 2025 at 05:28:26PM -0500, Eli Schwartz wrote:
> They are only used when running tests, and are included as depedencies
> of the test cases themselves already. Marking them to not build by
> default, means that 291 compile edges can be skipped when only running
> 
> ```
> meson setup builddir/
> ninja -C builddir/
> meson install -C builddir/
> ```
> 
> resulting in an overall much faster build. Instead they will be compiled
> on-demand by `meson test`, only for users that actually run the tests.
> 
> Signed-off-by: Eli Schwartz <[email protected]>

This also matches the behaviour of the legacy Makefiles.

Merged, thanks.

> ---
>  tests/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/meson.build b/tests/meson.build
> index 9cf6e3d..f1044b9 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -1,7 +1,9 @@
>  trees = static_library('trees', files('trees.S'), c_args: '-D__ASSEMBLY__',
> +                       build_by_default: false,
>                         include_directories: libfdt_inc)
>  
>  dumptrees = executable('dumptrees', files('dumptrees.c'),
> +                       build_by_default: false,
>                         link_with: trees, dependencies: libfdt_dep)
>  
>  dumptrees_dtb = custom_target(
> @@ -111,7 +113,7 @@ endif
>  
>  tests_exe = []
>  foreach t: tests
> -  tests_exe += executable(t, files(t + '.c'), dependencies: test_deps, link_args: extra_link_args)
> +  tests_exe += executable(t, files(t + '.c'), dependencies: test_deps, link_args: extra_link_args, build_by_default: false)
>  endforeach
>  
>  run_tests = find_program('run_tests.sh')

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

signature.asc (application/pgp-signature, 833 B)