Re: [PATCH v2 1/2] Makefile: deprecate in favor of Meson

David Gibson <[email protected]> Wed, 30 Apr 2025 21:56:16 +0700

Newsgroups	org.kernel.vger.devicetree-compiler
Message-ID	<aBI6EOjA6OYOz8oA@zatzit>

On Mon, Apr 28, 2025 at 09:41:42PM -0400, Eli Schwartz wrote:
> Building the python bindings is complicated and not very practical to do
> in a Makefile. The setuptools invocations previously used are confusing
> and don't work very well compared to Meson. Having two build systems
> that do different things is also confusing though.
> 
> Since Meson can do everything that Make can do, but the reverse is not
> true, we deprecate the latter and warn when you use it.
> 
> GNU Make can emit a $(warning) on every Makefile run, which is a bit
> noisly but means we don't need to have every target depend on a PHONY
> target (preventing built targets from being seen as up to date).

s/noisly/noisy/

I'm pretty ok with it being noisy.  Some minor nits in wording noted below.

> Signed-off-by: Eli Schwartz <[email protected]>
> ---
>  Makefile | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index a00123d..000dd85 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3,6 +3,12 @@
>  # Device Tree Compiler
>  #
>  
> +$(warning WARNING: Building dtc using the Makefile is deprecated, in favor of using the Meson build system instead.)
> +$(warning )
> +$(warning https://mesonbuild.com)

For succinctness, I suggest:

WARNING: Building dtc using make is deprecated in favour of using Meson (https://mesonbuild.com)

Note that British/Australian spelling is preferred for this project, hence "favour".

> +$(warning )
> +$(warning Use `meson setup builddir/ && ninja -C builddir/` to build, or `meson configure` to see build options.)

I'd prefer to suggest "meson compile -C builddir" here, rather than
directly invoking ninja, and I'd also like to list "meson test -C
builddir" as the replacement for "make check".

> +
>  #
>  # Version information will be constructed in this order:
>  # DTC_VERSION release version as MAJOR.MINOR.PATCH

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

signature.asc (application/pgp-signature, 833 B)