Re: [PATCH v3 4/4] fdtoverlaymerge: A tool that merges overlays

On Fri, May 23, 2025 at 02:44:15PM +0100, Simon Glass wrote:
> Hi Wasim,
> 
> On Mon, 19 May 2025 at 11:16, Wasim Nazir <[email protected]> wrote:
> >
> > From: Srivatsa Vaddagiri <[email protected]>
> >
> > Add a new command-line tool, fdtoverlaymerge, that merges two or more
> > overlay blobs using the fdt_overlay_merge() API. This tool is necessary
> > to simplify the process of combining multiple overlays into a single blob.
> 
> Normally this would be done in the bootloader, with the overlays in a
> FIT. What environment does this tool run in?

This tool is running in Android build system where we need to have
separate images for dtb and dtbo. Moreover, the dtbo is getting
build from multiple independent workspace.
I have provided more details here [1], hope it helps to clarify further
doubts.

[1] https://lore.kernel.org/all/[email protected]/

> 
> >
> > Signed-off-by: Srivatsa Vaddagiri <[email protected]>
> > Signed-off-by: Wasim Nazir <[email protected]>
> > ---
> >  .gitignore         |   1 +
> >  Makefile           |   4 +
> >  Makefile.utils     |   6 ++
> >  fdtoverlaymerge.c  | 223 +++++++++++++++++++++++++++++++++++++++++++++
> >  libfdt/version.lds |   1 +
> >  meson.build        |   2 +-
> >  6 files changed, 236 insertions(+), 1 deletion(-)
> >  create mode 100644 fdtoverlaymerge.c
> 
> How is this tested?

This is tested with our internal DT framework which comprises of
multiple soc & board level dtb & dtbo.
We comapre the output/final dt blob with & without this patch for
validations.

> 
> Regards,
> Simon

Regards,
Wasim