Re: [PATCH v2] checks: Remove check for graph child addresses

On Tue, Aug 12, 2025 at 11:51 AM Niklas Söderlund
<[email protected]> wrote:
>
> The dtc graph_child_address check can't distinguish between bindings
> where there can only be a single endpoint, and cases where there can be
> multiple endpoints.
>
> In cases where the bindings allow for multiple endpoints but only one is
> described false warnings about unnecessary #address-cells/#size-cells
> can be generated, but only if the endpoint described have an address of
> 0 (A), for single endpoints with a non-zero address (B) no warnings are
> generated.
>
> A)
>     ports {
>         #address-cells = <1>;
>         #size-cells = <0>;
>
>         port@0 {
>             #address-cells = <1>;
>             #size-cells = <0>;
>
>             sourceA: endpoint@0 {
>                 reg = <0>
>             };
>         };
>     };
>
> B)
>     ports {
>         #address-cells = <1>;
>         #size-cells = <0>;
>
>         port@0 {
>             #address-cells = <1>;
>             #size-cells = <0>;
>
>             sourceB: endpoint@1 {
>                 reg = <1>
>             };
>         };
>     };
>
> Remove the check as it is somewhat redundant now that we can use schemas
> to validate the full node.
>
> Signed-off-by: Niklas Söderlund <[email protected]>
> ---
> Changes since v2
> - Rebase after 6.17-rc1 merge window closed.
> ---
>  checks.c | 27 +--------------------------
>  1 file changed, 1 insertion(+), 26 deletions(-)

Reviewed-by: Rob Herring (Arm) <[email protected]>