[PATCH] dtc: Remove unused dts_version in dtc-lexer.l

Nathan Chancellor <[email protected]> Wed, 25 Mar 2026 17:13:44 -0700
Newsgroups org.kernel.vger.devicetree-compiler
Message-ID <20260325-dtc-lexer-remove-dts_version-v1-1-0b5d64903bbb@kernel.org>
A recent strengthening of -Wunused-but-set-variable (enabled with -Wall)
in clang under a new subwarning, -Wunused-but-set-global, points out an
unused static global variable in dtc-lexer.l:

  ../dtc-lexer.l:42:12: error: variable 'dts_version' set but not used [-Werror,-Wunused-but-set-global]
     42 | static int dts_version = 1;
        |            ^

This variable has been unused since commit 4e1a0a0 ("Remove support for
the legacy DTS source file format."). Remove it to clear up the warning.

Signed-off-by: Nathan Chancellor <[email protected]>
---
 dtc-lexer.l | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dtc-lexer.l b/dtc-lexer.l
index 15d585c..1b129b1 100644
--- a/dtc-lexer.l
+++ b/dtc-lexer.l
@@ -39,8 +39,6 @@ extern bool treesource_error;
 #define DPRINT(fmt, ...)	do { } while (0)
 #endif
 
-static int dts_version = 1;
-
 #define BEGIN_DEFAULT()		DPRINT("<V1>\n"); \
 				BEGIN(V1); \
 
@@ -101,7 +99,6 @@ static void PRINTF(1, 2) lexical_error(const char *fmt, ...);
 
 <*>"/dts-v1/"	{
 			DPRINT("Keyword: /dts-v1/\n");
-			dts_version = 1;
 			BEGIN_DEFAULT();
 			return DT_V1;
 		}

---
base-commit: caf7465c5d60a56e00ea8c6b6eeb4e443371f815
change-id: 20260325-dtc-lexer-remove-dts_version-dbf0fcd4aec4

Best regards,
--  
Nathan Chancellor <[email protected]>