Re: [PATCH] label: collect labels to __phandles__ node in interger format

David Gibson <[email protected]> Thu, 30 Apr 2026 16:52:40 +1000
Newsgroups org.kernel.vger.devicetree-compiler
Message-ID <afL8OLcjZ4umn9uD@zatzit>
--GFjk9GvPX+jlLbdk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 06, 2026 at 02:38:56AM +0000, yuanlinyu wrote:
> > From: David Gibson <[email protected]>
> > Sent: Friday, October 3, 2025 2:29 PM
> > To: yuanlinyu <[email protected]>
> > Cc: [email protected]
> > Subject: Re: [PATCH] label: collect labels to __phandles__ node in inte=
rger
> > format
> >=20
> > On Mon, Sep 29, 2025 at 02:33:19AM +0000, yuanlinyu wrote:
> > > Hi David and other devicetree developer,
> > >
> > > Could you help review this change ?
> >=20
> > Sorry for the lack of reply.  I'm not going to apply this.  There's cur=
rently a big
> > discussion underway on this list (amongst others) about better ways of =
doing
> > runtime device tree modifications.  ("Re:
> > Device tree representation of (hotplug) connectors: discussion at ELCE"=
).
> >=20
> > My main point in that thread is that we need to reconsider the design o=
f this
> > end-to-end, and not add more hacks on top of the overlay mechanism whic=
h was
> > never really designed for this.
>=20
> Hi maintainer,
> Is it possible to reconsider to take this change ?

Not unless I'm given concrete reasons I should reconsider it.

> Or could you share the idea to improve it ?

I barely have time to give feedback to much better considered
proposals than this, so not really, no.  Look at that thread and
others on the lists and join the discussion there.


>=20
> >=20
> > >
> > > thanks
> > > -----Original Message-----
> > > From: yuanlinyu <[email protected]>
> > > Sent: Monday, September 1, 2025 8:23 PM
> > > To: David Gibson <[email protected]>
> > > Cc: [email protected]; yuanlinyu
> > > <[email protected]>
> > > Subject: [PATCH] label: collect labels to __phandles__ node in
> > > interger format
> > >
> > > Currently labels are collect to __symbols__ node in path string
> > > format, the libufdt have no support of it when do overlay.
> > >
> > > Add a new method which collect labels in __phandles__ node which each
> > > entry is an interger format, it will allow libufdt to keep labels when
> > > do (stack) overlay.
> > >
> > > The new method including below points, 1. add an option -P for dtc
> > > tool, it will create __phandles__ node and labels in interger foramt
> > > 2. add new function in fdt_overlay.c to support merge __phandles__
> > > node 3. add overlay test which test -P option
> > > ---
> > >  dtc.c                |  18 +++-
> > >  dtc.h                |   4 +-
> > >  libfdt/fdt_overlay.c | 250 ++++++++++++++++++++++++++++++++++++++---=
--
> > >  livetree.c           |  76 +++++++++++--
> > >  tests/run_tests.sh   |  84 +++++++++++++++
> > >  5 files changed, 392 insertions(+), 40 deletions(-)
> >=20
> > --
> > David Gibson (he or they)	| I'll have my music baroque, and my code
> > david AT gibson.dropbear.id.au	| minimalist, thank you, not the other w=
ay
> > 				| around.
> > http://www.ozlabs.org/~dgibson

--=20
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

--GFjk9GvPX+jlLbdk
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmny/C0ACgkQzQJF27ox
2GcfLw/6Auy60HT+WlXcy2/rDYnwog5SYKaMC0O5z1xqjr1qqv6wHF48BxptL9ee
3O/n9M5S7VAuAXVmoBoCtqynlMZE3cVuOBW6YeKOcXhLJHj7bfE4fmziFSH5JUii
BdflEFX2uLf0IgMtofRBlQYUsBXRQdKe42JwDYTy2wlIcKJC8wyr2Q9w1Ic497QJ
AGdXg6A4RYaVYV88fcsVohiWpRhE7weokbv65+yLYh1T7vDSZeldO2VHMhwMgzhr
lNq1USC5uB3u2cb92WqnOQ0rpTL8lCxHBT3E4u+ID6wHA8vpnYx5xCG3TfUXSEHA
FMDhOpj3kLvYCxSyxztqLVnzJl57mF42pRRX0B3BdImCuoKEBqXWt76pf2oqXzLH
yBG6v3lzQUD3pw9QohD3YnBEHPKX8VBcfeO+DO+T4tX+Dzd8JRHVZzGzuks3tNEL
1C6FLnhccmaQo7lxCegtMhvFaa2sXNDJLnu+mz4gvY4hOCLjCH8mlHRMnRQyGHWE
BuJrZPkhjGhytO3YEpJzVkRHnSUyjryj+QR5PpNbF8viI9EhVO7a1mn3l06NfRKd
BrBmy+MCvZKj+BBws8oCy8ViqbqBICiAfXxXcksFR/OF+JCG3YZmYixBdxWTujfB
Hg7edqQGVNsDEl2SPQH8ygkPNMmwsQRBNQC8AzbHUdh+gBGlKh8=
=wP87
-----END PGP SIGNATURE-----

--GFjk9GvPX+jlLbdk--