Re: [PATCH dt-schema 3/3] schemas: i2c: add generic interrupt name for I2C controllers

Hi Rob,

thanks for the super-fast review!

> > "smbus_alert" is a generic interrupt name for controllers, so document
> > it. Introduce also "irq" for the primary interrupt.
> 
> I wouldn't add "irq". It's kind of odd in that we have it for I2C
> devices in the first place and we don't try to do that anywhere else.

Yes, I am actually happy to remove "irq". I only added it for
consistency.

> > +  interrupt-names:
> > +    anyOf:
> > +      - {} # Any name is allowed.
> > +      - items:
> > +          enum:
> > +            - irq
> > +            - smbus_alert
> 
> It doesn't really matter with the {}, but the 2nd entry is only true
> if interrupt-names only contains these 2 names. I'd use 'contains'
> rather than 'items' here.

So, just replace "items:" with "contains:", right? Should I also change
this for I2C targets and add this chunk to patch 2?

All the best,

   Wolfram

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAma+TDIACgkQFA3kzBSg
Kba5JA//TdfgprHtfh5UUQdgv79CEijte475hZ8Ajhd0arA8+zTS2vrHM0zmJSgM
y25+z5XwTeZ51GNvRg8dWoLQ14fG8BF02/Mq7TB8EjMdc9d6rL1gwLzBl0a0NmPt
JSRvjlJLRe/z9cY8LuFGJ5a6r6AVmlizNlH7c+zdop3uTw68rWGg9ngkW1hfPwRZ
X/P+Rn1rNuyHHhf+EUgaozEi7A6AKggYW7Z1mFHDgabrecps21xz8Rizaw2selT9
tNsB/lbzoO6cIhpH8Qbeq5GHdh3vvtNeYqYnYvHkvXVXrqnxVSPpw6Drc2pafQ9N
ZOgrbaQMf4f25OYOzjix04XXCnrVXf5kgE2S55Y2wZ0tzN483L2QNmuz7Zgu1ZpQ
GZ2Ll4VKLjXzhj75Up+/0gOaTrhwOuL/a3CAAJgIkkokL8uF3DZSSzk00g2mpTVE
mjMElrkfEmWEWkAcdRqF/FNOx2SA0fDuOz0T6sb9WxWMe3UeBtw+F6SWWNmVdo9F
EHhxHxJj+yq3XQauHW80YzK6eQ4pEJOBSdYPY0IqX5IiZArau+fnTXq4G5uSBQEO
DeJ1TzXAU2qgAkCGlafl0aLp04KsK9amJtLWT+9HHfOqFDqAEl8JGRi4TiuRzGa7
NiOBo6qjzEauZ7ec7kvWVJLVvLXtUvJ0oQlMNkCICJl2nvbaBGc=
=UY4B
-----END PGP SIGNATURE-----